On Wed, Feb 23, 2011 at 09:08:34AM -0800, Benny Halevy wrote: > On 2011-02-23 08:48, Chuck Lever wrote: > > > > On Feb 22, 2011, at 2:43 PM, Benny Halevy wrote: > > > >> Fix bug introduced in patch > >> 85a56480 NFSD: Update XDR decoders in NFSv4 callback client > >> > >> Although decode_cb_sequence4resok ignores highest slotid and target highest slotid > >> it must account for their space in their xdr stream when calling xdr_inline_decode > > > > The real problem is that decoding for the next operation in the compound will start too early in the buffer, because we didn't account for the ignored 8 bytes here, yes? > > Right on the spot. So actually I guess there is another bug here, which is a subset of http://wiki.linux-nfs.org/wiki/index.php/Server_4.0_and_4.1_issues#Callback_error_handling The server should be setting the appropriate sequence flag when it (rightly or wrongly) things that a cb reply is garbage (not sure which flag off the top of my head), and pynfs should be insisting that the flag be set on any further sequence flags. --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
