On 2011-02-22 16:11, J. Bruce Fields wrote: > On Tue, Feb 22, 2011 at 02:43:22PM -0800, Benny Halevy wrote: >> Fix bug introduced in patch >> 85a56480 NFSD: Update XDR decoders in NFSv4 callback client >> >> Although decode_cb_sequence4resok ignores highest slotid and target highest slotid >> it must account for their space in their xdr stream when calling xdr_inline_decode > > Thanks, applying for 2.6.38. (How come you caught this, and I didn't? > I guess it's just that the object code depends more on the callback > returns?) That's a great question. I caught it by testing cb_layoutrecall, both with the objects layout and with the files layout with the patch I sent for PNFSD_LEXP to recall the layout on truncate. cb_recall decoding should be broken too at the server. It's possible nothing really depends on its status. Benny > > --b. > >> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html