On Mon, 2011-02-21 at 10:49 -0800, Benny Halevy wrote:
> On 2011-02-21 09:49, Fred Isaman wrote:
> > @@ -965,11 +968,18 @@ static int nfs_flush_one(struct inode *inode, struct list_head *head, unsigned i
> > struct nfs_page *req;
> > struct page **pages;
> > struct nfs_write_data *data;
> > + int ret;
> >
> > data = nfs_writedata_alloc(npages);
> > - if (!data)
> > - goto out_bad;
> > -
> > + if (!data) {
> > + while (!list_empty(head)) {
> > + req = nfs_list_entry(head->next);
>
> nit: it'd be cleaner to define a nfs_list_first_entry helper in nfs_page.h
> rather than using a combination of list helpers and open code (head->next).
No thanks! Let's not add lots of helpers for trivial stuff unless that
results in a clear gain in type safety.
Trond
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@xxxxxxxxxx
www.netapp.com
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
