Re: [PATCH] nfs: don't queue synchronous NFSv4 close rpc_release to nfsiod

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 16 Feb 2011 10:21:17 -0500
Trond Myklebust <Trond.Myklebust@xxxxxxxxxx> wrote:

> On Wed, 2011-02-16 at 09:50 -0500, Jeff Layton wrote: 
> > Thanks Trond,
> > 
> > This builds, but I can't plug in the module:
> > 
> > [  103.540405] sunrpc: Unknown symbol __wake_up_locked_key (err 0)
> > 
> > ...I think __wake_up_locked_key will need to be exported too. I'll do
> > that and then test this out later today.
> 
> Thanks! I've added an EXPORT_SYMBOL_GPL() for __wake_up_locked_key to
> the patch.
> 

So far this patch looks good. I've been able to reproduce the problem
much more reliably with this patch and running the cthon special tests:

---------------------------[snip]-------------------------
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 40381d2..0e3d75f 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -1849,6 +1849,7 @@ static void nfs4_free_closedata(void *data)
        struct nfs4_closedata *calldata = data;
        struct nfs4_state_owner *sp = calldata->state->owner;
 
+       msleep(100);
        if (calldata->roc)
                pnfs_roc_release(calldata->state->inode);
        nfs4_put_open_state(calldata->state);
---------------------------[snip]-------------------------

...with your patch on top of that, I've not been able to reproduce the
problem so far after around 20 passes. I'll plan to let the tests run
this evening to make sure, but initial results are good.

Cheers,
-- 
Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux