On Tue, Feb 15, 2011 at 9:58 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > On Tue, Feb 15, 2011 at 09:48:26AM -0500, Fred Isaman wrote: >> pnfs_free_lseg_list, besides calling free_lseg, also potentially >> removes the layout from the clients list of inodes with layouts. > > Looks like the routine than changed from the mainline variant > I looked at. I took a quick look at the one from pnfs-submit, > which looks quite suspicios, as it special cases the first item > on the list without a good explanation and then iterates the list. > I can add a comment, but every element on the list is from the same layout, so we just grab the layout from the first item in the list. > Does your tree have another caller of pnfs_free_lseg_list? Yes, there are several callers, two in callback_proc.c for example which are both potentially actual lists. Fred > If not > please just open code the right thing in the caller, instead of > pretending we're dealing with a list if you're always dealing with > one entry. If the tree grows a caller that needs to deal with a list > with more than 1 entry we can revisit if there's a point in sharing > code. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
