On Wed, Feb 09, 2011 at 12:01:18AM -0500, Christoph Hellwig wrote: > > +static > > +void nfsd_break_deleg_cb(struct file_lock *fl) > > Very weird formatting. Please make it either > > static void nfsd_break_deleg_cb(struct file_lock *fl) > > or > > static void > nfsd_break_deleg_cb(struct file_lock *fl) > > but never just put the static on a line of it's own. Agreed. Those two lines were actually untouched by this patch, no matter what diff thinks--but I'm just as happy to fix it up while we're there; done. --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html