On Thu, 02 Dec 2010 11:31:23 -0800
Frank Filz <ffilzlnx@xxxxxxxxxx> wrote:
> The problem was use of an int32, which when converted to a uint64
> is sign extended resulting in a fileid that doesn't fit in 32 bits
> even though the intent of the function is to fit the fileid into
> 32 bits.
>
> Signed-off-by: Frank Filz <ffilzlnx@xxxxxxxxxx>
> ---
> fs/nfs/inode.c | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c
> index 314f571..bc0b938 100644
> --- a/fs/nfs/inode.c
> +++ b/fs/nfs/inode.c
> @@ -89,7 +89,11 @@ int nfs_wait_bit_killable(void *word)
> */
> u64 nfs_compat_user_ino64(u64 fileid)
> {
> - int ino;
> +#ifdef CONFIG_COMPAT
> + compat_ulong_t ino;
> +#else
> + unsigned long ino;
> +#endif
>
> if (enable_ino64)
> return fileid;
Looks like this patch fell through the cracks during the merge window?
In any case, it looks sane enough to me...
Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
