On Mon, Jan 17, 2011 at 1:42 PM, Jesper Juhl <jj@xxxxxxxxxxxxx> wrote: > On Mon, 17 Jan 2011, Fred Isaman wrote: > >> On Sun, Jan 16, 2011 at 3:50 PM, Jesper Juhl <jj@xxxxxxxxxxxxx> wrote: >> > strrchr() can return NULL if nothing is found. If this happens we'll >> > dereference a NULL pointer in >> > fs/nfs/nfs4filelayoutdev.c::decode_and_add_ds(). >> > >> > I tried to find some other code that guarantees that this can never >> > happen but I was unsuccessful. So, unless someone else can point to some >> > code that ensures this can never be a problem, I believe this patch is >> > needed. >> > >> >> The only guarantee is the assumption that the server isn't sending >> garbage. As such, this patch looks good to me. >> > > Thanks. Can I add your Acked-by: if/when I resend the patch? > Yes. Fred > -- > Jesper Juhl <jj@xxxxxxxxxxxxx> http://www.chaosbits.net/ > Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html > Plain text mails only, please. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
