On Tue, 2011-01-04 at 16:57 -0500, Dr. J. Bruce Fields wrote: > On Tue, Jan 04, 2011 at 04:50:33PM -0500, Trond Myklebust wrote: > > On Tue, 2011-01-04 at 13:43 -0800, Simon Kirby wrote: > > > On Tue, Jan 04, 2011 at 04:33:12PM -0500, Trond Myklebust wrote: > > > > > > > On Tue, 2011-01-04 at 13:25 -0800, Simon Kirby wrote: > > > > > I finally got around to setting up idmapd properly with libnss-mysql, and > > > > > in doing so, I forgot that I had enabled nfs4_disable_idmapping=Y with > > > > > this patch applied. With this option set on the client, and the server > > > > > set up normally, I get EINVAL from chown's fchowna(): > > > > > > > > > > # chown testuser:testuser test > > > > > chown: changing ownership of `test': Invalid argument > > > > > # echo N > /sys/module/nfs/parameters/nfs4_disable_idmapping > > > > > # chown testuser:testuser test > > > > > # > > > > > > > > > > This happened on 2.6.37-rc5-git4, but I just reproduced it with > > > > > 2.6.37-rc8-git5 as well. The server idmapd logs: > > > > > > > > > > rpc.idmapd[2987]: nss_getpwnam: name '1009999' does not map into domain 'localdomain' > > > > > rpc.idmapd[2987]: Server: (user) name "1009999" -> id "65534" > > > > > rpc.idmapd[2987]: nfsdcb: authbuf=10.10.52.0/24 authtype=group > > > > > rpc.idmapd[2987]: Server: (group) name "1009999" -> id "65534" > > > > > > > > > > (1009999 is the current uid/gid here.) > > > > > > > > > > I think you meant for this to fall back automatically, right? > > > > > > > > Did you remember to apply the patch 'NFSv4: Propagate the error > > > > NFS4ERR_BADOWNER to nfs4_do_setattr'? > > > > > > Yes, that patch is applied as part of the series. > > > > > > The -EINVAL is going back to userland's fchownat(). I expected > > > to see the "Reenabling the idmapper" printk() from within > > > nfs4_handle_exception(), but this didn't seem to happen. > > > > Hmm... Bruce, does the server actually return NFS4ERR_BADOWNER when it > > is supposed to? As far as I can see, nfs4idmap will consistently return > > NFS4ERR_BADNAME, which would be a bug here. > > Whoops. Looking at the spec.... Looks like BADNAME should be reserved > only for filenames? I'll fix that now. Sigh... I'll fix up the client patches to work around the server bug... -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@xxxxxxxxxx www.netapp.com -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
