On Tue, 2011-01-04 at 15:57 -0500, Trond Myklebust wrote:
> On Tue, 2011-01-04 at 15:42 -0500, andros@xxxxxxxxxx wrote:
> > From: Andy Adamson <andros@xxxxxxxxxx>
> >
> > Provide a unique callback identifier per SETCLIENTID call used to identify the
> > v4.0 callback service associated with the clientid.
> >
> > Do not worry about wrap around. Zero value means unset.
> >
> > Signed-off-by: Andy Adamson <andros@xxxxxxxxxx>
> > ---
> > fs/nfs/nfs4proc.c | 5 +++++
> > fs/nfs/nfs4state.c | 1 +
> > include/linux/nfs_fs_sb.h | 1 +
> > include/linux/nfs_xdr.h | 1 +
> > 4 files changed, 8 insertions(+), 0 deletions(-)
> >
> > diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> > index 78b0899..6652e39 100644
> > --- a/fs/nfs/nfs4proc.c
> > +++ b/fs/nfs/nfs4proc.c
> > @@ -3470,6 +3470,8 @@ do_state_recovery:
> > return -EAGAIN;
> > }
> >
> > +static u32 current_cb_ident = 1;
> > +
> > int nfs4_proc_setclientid(struct nfs_client *clp, u32 program,
> > unsigned short port, struct rpc_cred *cred,
> > struct nfs4_setclientid_res *res)
> > @@ -3478,6 +3480,7 @@ int nfs4_proc_setclientid(struct nfs_client *clp, u32 program,
> > struct nfs4_setclientid setclientid = {
> > .sc_verifier = &sc_verifier,
> > .sc_prog = program,
> > + .sc_cb_ident = current_cb_ident++,
>
> How about instead using ida_get_new() in order to get a truly unique id
> in the range 1..0x7fffffff?
....
Actually, we might want to consider using idr_get_new(), since that
allows us to safely locate the struct nfs_client using idr_find()...
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@xxxxxxxxxx
www.netapp.com
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
