On Dec 22, 2010, at 4:50 PM, Bryan Schumaker wrote:
>
> This patch adds the nfs4 operation secinfo as a
> valid nfs rpc operation.
>
> Signed-off-by: Bryan Schumaker <bjschuma@xxxxxxxxxx>
> ---
> fs/nfs/nfs3proc.c | 1 +
> fs/nfs/nfs4proc.c | 35 +++++++++++++
> fs/nfs/nfs4xdr.c | 129 +++++++++++++++++++++++++++++++++++++++++++++++
> fs/nfs/proc.c | 1 +
> include/linux/nfs4.h | 1 +
> include/linux/nfs_xdr.h | 34 ++++++++++++
> 6 files changed, 201 insertions(+), 0 deletions(-)
>
> diff --git a/fs/nfs/nfs3proc.c b/fs/nfs/nfs3proc.c
> index 2b0e7c8..1237e04 100644
> --- a/fs/nfs/nfs3proc.c
> +++ b/fs/nfs/nfs3proc.c
> @@ -885,4 +885,5 @@ const struct nfs_rpc_ops nfs_v3_clientops = {
> .lock = nfs3_proc_lock,
> .clear_acl_cache = nfs3_forget_cached_acls,
> .close_context = nfs_close_context,
> + .secinfo = NULL,
> };
I believe the practice of setting global constant function pointer fields such as this one to NULL is frowned upon. C ensures that's their default value.
> diff --git a/fs/nfs/proc.c b/fs/nfs/proc.c
> index 504dd25..36f482c 100644
> --- a/fs/nfs/proc.c
> +++ b/fs/nfs/proc.c
> @@ -740,4 +740,5 @@ const struct nfs_rpc_ops nfs_v2_clientops = {
> .lock = nfs_proc_lock,
> .lock_check_bounds = nfs_lock_check_bounds,
> .close_context = nfs_close_context,
> + .secinfo = NULL,
> };
Ditto.
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
