On Dec 22, 2010, at 7:14 PM, Trond Myklebust wrote: > On Wed, 2010-12-22 at 18:54 -0500, Jim Rees wrote: >> Bryan Schumaker wrote: >> >> This patch changes nfs4_call_sync() from a macro into a >> static inline function. >> >> Makes sense, but why change the arguments? > > Not sure I understand. Do you mean the change from untyped args and res > to nfs4_sequence_args and nfs4_sequence_res? That would be to enable > proper type checking. > > That part of the macro was always a dirty hack which relied on the > sequence related arguments always having the same names, and which only > served to avoid having to type those 8 characters per argument... It would be nice to document that improvement in the patch description. -- Chuck Lever chuck[dot]lever[at]oracle[dot]com -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
