Re: [PATCH 04/14] pnfs: wave 2: change layout state seqlock to a spinlock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 21, 2010 at 10:26 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> On Mon, Dec 20, 2010 at 09:20:36PM -0500, Fred Isaman wrote:
>> This prepares for future changes, where the layout state needs
>> to change atomically with several other variables.  In particular,
>> it will need to know if lo->segs is empty, as we test that instead
>> of manipulating the NFS_LAYOUT_STATEID_SET bit.  Moreover, the
>> layoutstateid is not really a read-mostly structure, as it is
>> written almost as often as it is read.
>
> It also renames a couple of functions.
>

I assume you refer to pnfs_get_layout_stateid ->
pnfs_choose_layoutget_stateid.  I was thinking of them as entirely
different functions, as one actually changed the stateid, and the
other doesn't.  But I can put a comment in the description clarifying
that.

Fred

> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux