On Mon, Dec 06, 2010 at 07:31:04PM -0500, Jim Rees wrote: > J. Bruce Fields wrote: > > Thanks to dysbr01@xxxxxx for noticing that the debugging printk in > the v3 write procedure can print >2GB offsets as negative numbers: > https://bugzilla.kernel.org/show_bug.cgi?id=23342 > > Signed-off-by: J. Bruce Fields <bfields@xxxxxxxxxx> > --- > fs/nfsd/nfs3proc.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/fs/nfsd/nfs3proc.c b/fs/nfsd/nfs3proc.c > index 5b7e302..2247fc9 100644 > --- a/fs/nfsd/nfs3proc.c > +++ b/fs/nfsd/nfs3proc.c > @@ -151,10 +151,10 @@ nfsd3_proc_read(struct svc_rqst *rqstp, struct nfsd3_readargs *argp, > __be32 nfserr; > u32 max_blocksize = svc_max_payload(rqstp); > > - dprintk("nfsd: READ(3) %s %lu bytes at %lu\n", > + dprintk("nfsd: READ(3) %s %lu bytes at %Lu\n", > > Isn't "llu" preferred over "Lu" these days? Uh, OK, reading sprintf(3), "L" seems to only be meaningful for floating point, and "ll" a long long. Looking at the kernel's printk(), "L" seems to be a synomym for "ll". Both seem to be used all over. I'm leaving it as is out of laziness and consistency with the one preexisting use in this file, unless someone wants to argue otherwise. --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
