On Tue, 5 Oct 2010, Timo Aaltonen wrote:
On Fri, 1 Oct 2010, Sachin Prabhu wrote:
NFS4 clients appear to have problems reclaiming locks after a server
reboot. I can recreate the issue on 2.6.34.7-56.fc13.x86_64 on a Fedora
system.
The problem appears to happen in cases where after a reboot, a WRITE call
is made just before the RENEW call. In that case, the NFS4ERR_STALE_STATEID
is returned for the WRITE call which results in NFS_STATE_RECLAIM_REBOOT
being set in the state flags. However the NFS4ERR_STALE_CLIENTID returned
for the subsequent RENEW call is handled by
nfs4_recovery_handle_error() -> nfs4_state_end_reclaim_reboot(clp);
which ends up setting the state flag to NFS_STATE_RECLAIM_NOGRACE and
clearing the NFS_STATE_RECLAIM_REBOOT in nfs4_state_mark_reclaim_nograce().
The process of reclaiming the locks then seem to hit another roadblock in
nfs4_open_expired() where it fails to open the file and reset the state. It
ends up calling nfs4_reclaim_locks() in a loop with the old stateid in
nfs4_reclaim_open_state().
By commenting out the call to nfs4_state_end_reclaim_reboot(clp) in
nfs4_recovery_handle_error(), the client was able to handle this particular
scenario properly.
Has any one else seen this issue?
could this be related to the bug I was seeing with nfsv4 (now using v3 with
success):
https://bugzilla.kernel.org/show_bug.cgi?id=15973
though the error returned by the server is BAD_STATEID..
At least testing .37rc2 has so far been positive, suggesting that the bug
is fixed there.
--
Timo Aaltonen
Systems Specialist, Aalto IT
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
