On Thu, Nov 18, 2010 at 10:05 AM, Trond Myklebust <trond.myklebust@xxxxxxxxxx> wrote: > On Thu, 2010-11-18 at 09:42 -0500, William A. (Andy) Adamson wrote: >> On Wed, Nov 17, 2010 at 6:26 PM, Trond Myklebust >> <trond.myklebust@xxxxxxxxxx> wrote: >> > On Tue, 2010-11-16 at 22:36 -0500, andros@xxxxxxxxxx wrote: >> > >> > In NFSv4.0, you basically want to set the nfs_client in >> > nfs_callback_compound() (using the server's address and the >> > 'callback_ident' argument). >> >> And if the nfs_client is not found should we SVC_DROP the request? >> NFS4ERR_BADHANDLE? > > We can still drop the request in nfs4_callback_compound(). OK > >> > >> > In NFSv4.1, you need to set it in the OP_SEQUENCE decode callback, but >> > there you need to be returning NFS4ERR_BADSESSION and/or >> > NFS4ERR_CONN_NOT_BOUND_TO_SESSION anyway... >> >> I don't see the difference between not finding the proper nfs_client >> in the pg_authenticate method and not finding it after decode in >> CB_SEQUENCE. > > In the NFSv4.1 case, the client callback server knows that the > connection is valid, 'cos we're the ones who set it up. All we care > about is to make sure the session is still valid. If it isn't, then > NFS4ERR_BADSESSION is the correct reply. > > NFSv4.0 is an altogether different kettle of fish since we need to > authenticate the connection too. Got it. I'll put out a version 2. -->Andy > > Trond > > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
