On Thu, 11 Nov 2010 00:21:27 +0530, "Aneesh Kumar K. V" <aneesh.kumar@xxxxxxxxxxxxxxxxxx> wrote: > On Wed, 10 Nov 2010 23:31:31 +0530, Aneesh Kumar K.V <aneesh.kumar@xxxxxxxxxxxxxxxxxx> wrote: > > > > Hi, > > > > I guess we are not marking the inode attribute as invalid when we set > > the ACL value. For ex: > > > > /d# mkdir sub3 > > /d# ls -dl sub3 > > drwxr-xr-x 2 root root 4096 Nov 10 17:56 sub3 > > /d# nfs4_setfacl -s A:fd:EVERYONE@:rwax sub3 > > /d# ls -dl sub3 > > drwxr-xr-x 2 root root 4096 Nov 10 17:56 sub3 > > /d# > > > > > > On the server i have the mode bits as > > /d# ls -dl sub3 > > drwxrwxrwx 2 root root 4096 Nov 10 17:56 sub3 > > /d# > > We also have similar issue other way round. ie setting the mode bits > don't result in ACL values being invalidated. But a second request get > the right value of ACL as show below. > > /d# nfs4_getfacl x > A::OWNER@:rw > A::GROUP@:rw > A::EVERYONE@:r > /d# chmod 600 x > /d# nfs4_getfacl x > A::OWNER@:rw > A::GROUP@:rw > A::EVERYONE@:r > /d# > > Expected value is > > /d# nfs4_getfacl x > A::OWNER@:rw > The below patch fix the problem for me. If this is the right way to fix, I can send a proper patch with commit message and s-o-b. diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index 0f24cdf..666a48b 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -3359,6 +3359,8 @@ static ssize_t nfs4_proc_get_acl(struct inode *inode, void *buf, size_t buflen) ret = nfs_revalidate_inode(server, inode); if (ret < 0) return ret; + if (NFS_I(inode)->cache_validity & NFS_INO_INVALID_ACL) + nfs_zap_acl_cache(inode); ret = nfs4_read_cached_acl(inode, buf, buflen); if (ret != -ENOENT) return ret; @@ -3387,6 +3389,11 @@ static int __nfs4_proc_set_acl(struct inode *inode, const void *buf, size_t bufl nfs_inode_return_delegation(inode); buf_to_pages(buf, buflen, arg.acl_pages, &arg.acl_pgbase); ret = nfs4_call_sync(server, &msg, &arg, &res, 1); + /* + * Acl update can result in inode attribute update. + * so mark the attribute cache invalid. + */ + NFS_I(inode)->cache_validity |= NFS_INO_INVALID_ATTR; nfs_access_zap_cache(inode); nfs_zap_acl_cache(inode); return ret; -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
