Re: [PATCH] nfs-utils: nfsstat: has_stats() does not function correctly for NFSv4 client stats

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 11/10/2010 11:27 AM, Jim Rees wrote:
> Harshula Jayasuriya wrote:
> 
>   On Tue, 2010-11-09 at 14:29 -0500, Chuck Lever wrote:
>   > Hi-
>   > 
>   > Why not use mountstats?  The /proc/net/rpc/nfs is destined for deprecation, I thought.
> 
>   Are you referring to /proc/self/mountstats? I didn't know about it.
>   nfsstat's get_stats() would have to be re-written. I can add that to my
>   TODO list, but not sure when I'll get to it. In the meantime, this patch
>   will fix the previously mentioned bugs and make the existing code a
>   little clearer.
> 
> We should either fix it or remove it.  Leaving it in and broken seems wrong
> even if the interface is depracated, especially since we have a fix.
Of course... I was not clear... I'll take the patch to fix the bug
but I don't think its worth whiled to teach nfsstat how read 
stats from /proc/self/mountstats... I would rather put the effort into
improving both the nfsiostat and mountstats command.

steved.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux