On Sun, Oct 31, 2010 at 07:10:57AM -0400, Christoph Hellwig wrote: > On Sat, Oct 30, 2010 at 05:31:14PM -0400, J. Bruce Fields wrote: > > We're depending on setlease to free the passed-in lease on failure. > > But we would be much better to just free it in the caller. I'ts much > more natural - caller allocates, caller frees, and it's also simpler. > > I'll send a patch to do so shortly, together with sorting out the > remaining nfs4d lock_manager_operations abuses. I think we're set with > that for 2.6.37, the setlease split can wait once we've sorted out the > lock freeing issue. I also have patches that get rid of fl_release_private, fl_mylease, and (almost done) fl_change. Unless you've a better suggestion I'll probably send them out for review and then queue them up with other nfsd changes for 2.6.38. --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
