On Thu, 2010-10-28 at 16:18 -0400, Andy Adamson wrote: > On Oct 28, 2010, at 3:35 PM, Trond Myklebust wrote: > > > On Thu, 2010-10-28 at 15:09 -0400, Fred Isaman wrote: > >> From: Andy Adamson <andros@xxxxxxxxxx> > >> > >> The NFSv4.1 session found in cb_sequence needs to be shared by other > >> callback operations in the same cb_compound. > >> Hold a reference to the session's nfs_client throughout the > >> cb_compound > >> processing. > > > > Wait... That isn't holding a reference. This patch ends up just > > taking a > > pointer. > > See comments in line. cb_sequence gets a reference to nfs_client and > it's (for nfsv4.1) held until nfs4_callback_compound is done > processing the compound. Yes, but that doesn't offer you any guarantee that the nfs_client still exists when you get to cb_sequence. > > What guarantees that the session+nfs_client won't die on you > > while you're processing the callback? Do we wait for callbacks to > > finish > > before closing the session? > > I think so. I'll look. It seems to me that is a "must have" requirement. Cheers Trond -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
