On Thu, 2010-10-28 at 08:05 +0200, Dan Carpenter wrote: > The intent was to test "*desc" for allocation failures, but it tests > "desc" which is always a valid pointer here. > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> > > diff --git a/fs/nfs/idmap.c b/fs/nfs/idmap.c > index dec47ed..4e2d9b6 100644 > --- a/fs/nfs/idmap.c > +++ b/fs/nfs/idmap.c > @@ -123,7 +123,7 @@ static ssize_t nfs_idmap_get_desc(const char *name, size_t namelen, > size_t desclen = typelen + namelen + 2; > > *desc = kmalloc(desclen, GFP_KERNEL); > - if (!desc) > + if (!*desc) > return -ENOMEM; > > cp = *desc; Thanks! Applied! Trond -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
