On Thu, 2010-10-28 at 09:16 +0200, walter harms wrote: > > Dan Carpenter schrieb: > > The decode_and_add_ds() should return NULL on failure. > > > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> > > > > diff --git a/fs/nfs/nfs4filelayoutdev.c b/fs/nfs/nfs4filelayoutdev.c > > index 51fe64a..098113c 100644 > > --- a/fs/nfs/nfs4filelayoutdev.c > > +++ b/fs/nfs/nfs4filelayoutdev.c > > @@ -219,6 +219,8 @@ decode_and_add_ds(__be32 **pp, struct inode *inode) > > goto out_err; > > } > > buf = kmalloc(rlen + 1, GFP_KERNEL); > > + if (!buf) > > + goto out_err; > > buf[rlen] = '\0'; > > memcpy(buf, r_addr, rlen); > > > > it seems that r_addr is a string, then kstdup() is emulated here. > > re, > wh Not quite. kstrdup() requires that the argument be a NUL-terminated string. The above code doesn't. Trond -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
