On Tue, Oct 26, 2010 at 01:27:18PM -0400, Trond Myklebust wrote: > On Tue, 2010-10-26 at 13:20 -0400, J. Bruce Fields wrote: > > On Tue, Oct 26, 2010 at 09:39:14AM -0400, Trond Myklebust wrote: > > > On Tue, 2010-10-26 at 09:17 -0400, Bryan Schumaker wrote: > > > > This patch renames the idmapper upcall program from nfs.upcall to nfs.idmap. > > > > It also changes the key type from id_resolver to nfs_idmap. > > ... > > > We should _not_ be doing this kind of user space api change after the > > > code has been merged by Linus. > > > > > > I don't mind a patch to the documentation that changes 'nfs.upcall' to > > > match the name given in nfs-utils, but it is too late to change the name > > > 'id_resolver': that should have been done before the merge window. > > > > There's precedent for fixing new interfaces before the final release, so > > it seems unlikely to be a huge problem before -rc1. > > > > Though agreed that there should still be a higher standard for changes > > made after the moment the interface is merged--and a slightly > > inconsistent name may not meet the standard.... > > The name isn't really inconsistent: we use "dns_resolver" for the DNS > upcall types, so "id_resolver" shouldn't really be a problem... OK, makes senses. --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
