On 2010-10-24 17:35, Jim Rees wrote: > Boaz Harrosh wrote: > > This patch does *not* break the header's independence. .i.e the header can > still be compiled independently without any other includes. Which means > some of the includes here are un-needed. > > Thanks! I tried removing all the includes but was too lazy to figure out > which one was really needed by simple_rpc_pipefs.c. Yup. The self-sustainability approach is the best one, i.e. header files should include the minimum number of other header files to satisfy their dependencies. I'll merge both patches squashed together then. Benny -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html