On Sun, 24 Oct 2010 21:21:30 -0400 "J. Bruce Fields" <bfields@xxxxxxxxxx> wrote: > Once an xprt has been deleted, there's no reason to allow it to be > enqueued--at worst, that might cause the xprt to be re-added to some > global list, resulting in later corruption. > > Signed-off-by: J. Bruce Fields <bfields@xxxxxxxxxx> Yep, this makes svc_close_xprt() behave the same way as svc_recv() which calls svc_delete_xprt but does not clear XPT_BUSY. The other branches in svc_recv call svc_xprt_received, but the XPT_CLOSE branch doesn't Reviewed-by: NeilBrown <neilb@xxxxxxx> NeilBrown > --- > net/sunrpc/svc_xprt.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c > index bef1e88..db90e4d 100644 > --- a/net/sunrpc/svc_xprt.c > +++ b/net/sunrpc/svc_xprt.c > @@ -938,7 +938,6 @@ void svc_close_xprt(struct svc_xprt *xprt) > > svc_xprt_get(xprt); > svc_delete_xprt(xprt); > - clear_bit(XPT_BUSY, &xprt->xpt_flags); > svc_xprt_put(xprt); > } > EXPORT_SYMBOL_GPL(svc_close_xprt); -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
