On Thu, Oct 21, 2010 at 12:32:34PM -0400, Christoph Hellwig wrote:
> > Pavel Emelyanov (37):
> > nfsd: Export get_task_comm for nfsd
>
> NAK. As mentioned in the reply to the patch series nfsd should
> just use current->comm.
Ugh, sorry: I did fix up the code, but I forgot the subject line; it was
committed as follows.
--b.
commit 049ef27b224ecc33958465fef83d5e4e8a056115
Author: Pavel Emelyanov <xemul@xxxxxxxxxxxxx>
Date: Thu Sep 23 18:26:58 2010 +0400
nfsd: Export get_task_comm for nfsd
The git://linux-nfs.org/~bfields/linux.git nfsd-next branch doesn't
compile when nfsd is a module with the following error:
ERROR: "get_task_comm" [fs/nfsd/nfsd.ko] undefined!
Replace the get_task_comm call with direct comm access, which is
safe for current.
Signed-off-by: Pavel Emelyanov <xemul@xxxxxxxxxx>
Signed-off-by: J. Bruce Fields <bfields@xxxxxxxxxx>
diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
index b278e44..7b2fa1d 100644
--- a/fs/nfsd/nfsctl.c
+++ b/fs/nfsd/nfsctl.c
@@ -129,12 +129,10 @@ static ssize_t nfsctl_transaction_read(struct file *file, char __user *buf, size
{
static int warned;
if (file->f_dentry->d_name.name[0] == '.' && !warned) {
- char name[sizeof(current->comm)];
printk(KERN_INFO
"Warning: \"%s\" uses deprecated NFSD interface: %s."
" This will be removed in 2.6.40\n",
- get_task_comm(name, current),
- file->f_dentry->d_name.name);
+ current->comm, file->f_dentry->d_name.name);
warned = 1;
}
if (! file->private_data) {
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
