On 10/11/2010 04:00 PM, Jim Rees wrote: > Chuck Lever wrote: > > >> It bothers me that there are two separate code paths in two separate > >> libraries for these two nearly identical cases. > > Are there? Where's the other one? > > The two implementations I'm aware of are both in libnfs.a. One is for > legacy RPC, and the other is for TI-RPC, and they both reside in > support/nfs/ (and thus in libnfs.a, which is shared by the daemons in > nfs-utils). What am I missing? > > Your svc_create_sock() duplicates code in svc_tli_create(), including the > calls to socket(), bind(), and listen(). > > I'll buy your argument that we shouldn't change the tirpc api and that > REUSEADDR is only half the fix. But it still bothers me. I agree that adding the use of REUSEADDR to the libtirpc API is probably not way to go... So I'll take the patch as is.. steved. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
