On Oct 11, 2010, at 12:16 AM, Neil Brown wrote: > On Sun, 10 Oct 2010 20:04:01 -0400 > Chuck Lever <chuck.lever@xxxxxxxxxx> wrote: > >> Steve- >> >> Here are fifteen patches which address several mount and mountd bugs >> and correct other minor problems in nfs-utils-1.2.3. Now that the >> bake-a-thon event has passed, folks should have some spare moments to >> review these. > > Hi, > here is another you might like to add to the list. Reviewed-by: Chuck Lever <chuck.lever@xxxxxxxxxx> > > gcc complained: > > client.c: In function 'init_netmask6': > client.c:181:1: warning: no return statement in function returning non-void > > and Suse' build system complained > > I: Program returns random data in a function > E: nfs-utils no-return-in-nonvoid-function client.c:181 > > when I built without --enable-ipv6 > > > Signed-off-by: NeilBrown <neilb@xxxxxxx> > > diff --git a/support/export/client.c b/support/export/client.c > index dbfc2b1..ba2db8f 100644 > --- a/support/export/client.c > +++ b/support/export/client.c > @@ -178,6 +178,7 @@ out_badprefix: > static int > init_netmask6(nfs_client *UNUSED(clp), const char *UNUSED(slash)) > { > + return 0; > } > #endif /* IPV6_SUPPORTED */ > -- chuck[dot]lever[at]oracle[dot]com -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html