On 09/23/2010 09:13 PM, Trond Myklebust wrote: > On Thu, 2010-09-23 at 08:56 -0400, Trond Myklebust wrote: >> On Thu, 2010-09-23 at 12:40 +0530, Suresh Jayaraman wrote: >>> On 09/22/2010 09:36 PM, Trond Myklebust wrote: >>>> On Mon, 2010-09-20 at 16:41 +0530, Suresh Jayaraman wrote: >>>>> Changes since last post: >>>>> >>>>> - NFS_MOUNT_NONLM definition remains unmodified as legacy binary mount >>>>> interface uses it >>>>> - Fixed an Oops in _nfs4_do_setlk() found during NFSv4 reboot recovery >>>>> - Rebased against Trond's nfs-2.6.git (nfs-for-2.6.37 branch) >>>>> >>>>> Thanks, >>>>> Suresh Jayaraman >>>>> >>>> >>>> Suresh, >>>> >>>> This still appears to break the binary mount interface. You need >>>> something in nfs_validate_mount_data() to convert the NFS_MOUNT_NONLM >>>> flag into (NFS_MOUNT_LOCAL_FLOCK | NFS_MOUNT_LOCAL_FCNTL). >>>> >>> >>> Good catch, thanks. Here's the fixed version (haven't tested it as I don't >>> find a simple way to test it and it looks obvious): >> >> Hi Suresh, >> >> This one looks good to me. >> >> Thanks! >> Trond > > Hmm... One thing to note: it would be nice to display the 'local_lock' > status in /proc/mounts. That can be applied as a separate patch, though. > Sounds good. I sent a separate patch for doing that. The man page needs to be updated too. I'll write the nfs-utils patch for doing it and send it. Thanks, -- Suresh Jayaraman -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
