On Thu, Sep 23, 2010 at 06:26:58PM +0400, Pavel Emelyanov wrote:
> > Why doesn't it simply use current->comm as countless other users?
>
> Yep, this is indeed better...
>
> The git://linux-nfs.org/~bfields/linux.git nfsd-next branch doesn't
> compile when nfsd is a module with the following error:
>
> ERROR: "get_task_comm" [fs/nfsd/nfsd.ko] undefined!
>
> Replace the get_task_comm call with direct comm access, which is
> safe for current.
>
> Signed-off-by: Pavel Emelyanov <xemul@xxxxxxxxxx>
Applied, thanks.
--b.
>
> ---
>
> diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
> index 83c82ed..b6e192d 100644
> --- a/fs/nfsd/nfsctl.c
> +++ b/fs/nfsd/nfsctl.c
> @@ -129,12 +129,10 @@ static ssize_t nfsctl_transaction_read(struct file *file, char __user *buf, size
> {
> static int warned;
> if (file->f_dentry->d_name.name[0] == '.' && !warned) {
> - char name[sizeof(current->comm)];
> printk(KERN_INFO
> "Warning: \"%s\" uses deprecated NFSD interface: %s."
> " This will be removed in 2.6.40\n",
> - get_task_comm(name, current),
> - file->f_dentry->d_name.name);
> + current->comm, file->f_dentry->d_name.name);
> warned = 1;
> }
> if (! file->private_data) {
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
