Re: [PATCH 2/7] sunrpc/cache: fix recent breakage of cache_clean_deferred

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 22, 2010 at 12:55:06PM +1000, NeilBrown wrote:
> commit 6610f720e9e8103c22d1f1ccf8fbb695550a571f
> broke cache_clean_deferred as entries are no longer added to the
> pending list for subsequent revisiting.
> 
> So put those requests back on the pending list.

Whoops, clearly correct.  Thanks!

--b.

> 
> Signed-off-by: NeilBrown <neilb@xxxxxxx>
> ---
>  net/sunrpc/cache.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c
> index 62078be..a9e850e 100644
> --- a/net/sunrpc/cache.c
> +++ b/net/sunrpc/cache.c
> @@ -678,8 +678,10 @@ void cache_clean_deferred(void *owner)
>  	spin_lock(&cache_defer_lock);
>  
>  	list_for_each_entry_safe(dreq, tmp, &cache_defer_list, recent) {
> -		if (dreq->owner == owner)
> +		if (dreq->owner == owner) {
>  			__unhash_deferred_req(dreq);
> +			list_add(&dreq->recent, &pending);
> +		}
>  	}
>  	spin_unlock(&cache_defer_lock);
>  
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux