On Tue, 2010-09-21 at 15:36 -0400, Trond Myklebust wrote: > On Tue, 2010-09-21 at 15:20 -0400, J. Bruce Fields wrote: > > All I need to do is mount nfs4.1 and run cthon -s. The last output I > > see from the test is: > > > > check for proper open/unlink operation > > nfsjunk files before unlink: > > > > Oh... I bet I see what it is. > > It's that damned res->sr_slotid = NFS4_MAX_SLOT_TABLE and related > initialisation junk that's biting us in the arse again... > > I'll fix it... Does this work? Cheers Trond ------------------------------------------------------------------------------------- NFSv4.1: Fix the slotid initialisation in nfs_async_rename() From: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx> Signed-off-by: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx> --- fs/nfs/nfs4proc.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index c46e45e..72aa706 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -2550,6 +2550,7 @@ static void nfs4_proc_unlink_setup(struct rpc_message *msg, struct inode *dir) args->bitmask = server->cache_consistency_bitmask; res->server = server; + res->seq_res.sr_slotid = NFS4_MAX_SLOT_TABLE; msg->rpc_proc = &nfs4_procedures[NFSPROC4_CLNT_REMOVE]; } @@ -2575,6 +2576,7 @@ static void nfs4_proc_rename_setup(struct rpc_message *msg, struct inode *dir) msg->rpc_proc = &nfs4_procedures[NFSPROC4_CLNT_RENAME]; arg->bitmask = server->attr_bitmask; res->server = server; + res->seq_res.sr_slotid = NFS4_MAX_SLOT_TABLE; } static int nfs4_proc_rename_done(struct rpc_task *task, struct inode *old_dir, -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
