Re: [PATCH 4/8] nfs: standardize the rename response container

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 15 Sep 2010 11:29:38 -0400
Chuck Lever <chuck.lever@xxxxxxxxxx> wrote:

> > index 60fa509..6265fa8 100644
> > --- a/include/linux/nfs_xdr.h
> > +++ b/include/linux/nfs_xdr.h
> > @@ -411,6 +411,15 @@ struct nfs_renameargs {
> > 	struct nfs4_sequence_args	seq_args;
> > };
> > 
> > +struct nfs_renameres {
> > +	const struct nfs_server *	server;
> > +	struct nfs4_change_info		old_cinfo;
> > +	struct nfs_fattr *		old_fattr;
> > +	struct nfs4_change_info		new_cinfo;
> > +	struct nfs_fattr *		new_fattr;
> > +	struct nfs4_sequence_res	seq_res;
> > +};
> 
> Likewise.  Is #ifdef CONFIG_NFS_V4 needed here?  I guess the question is, have you tried building with CONFIG_NFS_V4 disabled?
> 

Yes, I have built this with v4 disabled and it worked just fine. The
#ifdef isn't really needed. I suppose we could add that in to save
a bit of memory but it's probably not worth it. Note that nfs_removeres
has the same sort of fields and they aren't wrapped in #ifdef's.

-- 
Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux