On Fri, Sep 10, 2010 at 06:37:03PM -0400, Trond Myklebust wrote: > struct module *owner = THIS_MODULE; > > > } > > ...although the struct module could probably indeed be part of > pnfs_layoutdriver_type too. If we only ever have one instances of the ops per type that's absolutely the way to go. const ops structures are nice to have, but if means making the code more complex just for that there's no point. Take a look at e.g. struct file_system_type. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html