Re: [PATCH 08/13] RFC: pnfs: filelayout: introduce minimal file layout driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 10, 2010 at 03:31:51PM -0400, Trond Myklebust wrote:
> > +	tristate
> > +	depends on NFS_FS && NFS_V4_1
> > +	default m
> 
> Should be 'default y', otherwise it has an implicit dependency on
> CONFIG_MODULES.

No, it should not have a default statement at all.  The only reason to
put in a default statement is to keep existing code working when it's
split into multiple options, which this is not.  This is not just my
opinion, btw - Linus has frequently whacked people for introducing pointless
defaults in the past.

And even if it was okay sometimes pnfs nowhere is near important enough
to add it in Kconfig.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux