On 09/07/2010 12:26 PM, Chuck Lever wrote:
> At some point, when the kernel starts to support "vers=4,rdma" mounts,
> we will want the mount.nfs command to pass "vers=4,rdma" mounts
> instead of rejecting them.
>
> Assuming that the kernel will reject these today with EPROTONOSUPPORT,
> that would cause the version fallback logic to go to "vers=3,rdma"
> automatically. So the extra check we have now is not needed anyway.
>
> Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx>
> ---
>
> utils/mount/stropts.c | 7 -------
> 1 files changed, 0 insertions(+), 7 deletions(-)
>
> diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c
> index 9695c73..a8b22ce 100644
> --- a/utils/mount/stropts.c
> +++ b/utils/mount/stropts.c
> @@ -302,13 +302,6 @@ static int nfs_set_version(struct nfsmount_info *mi)
>
> if (strncmp(mi->type, "nfs4", 4) == 0)
> mi->version = 4;
> - else {
> - unsigned long protocol;
> - if (!nfs_nfs_protocol(mi->options, &protocol))
> - return 0;
> - if (protocol == NFSPROTO_RDMA)
> - mi->version = 3;
> - }
>
> /*
> * If we still don't know, check for version-specific
>
This is a show stopper... We can default to v4 because the callbacks.
steved.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
