On Mon, 2010-09-06 at 11:38 +0800, Bian Naimeng wrote:
> spkm3 miss returning error to up layer when import security context,
> it may be return ok though it has failed to import security context.
>
> Signed-off-by: Bian Naimeng <biannm@xxxxxxxxxxxxxx>
>
>
> ---
> net/sunrpc/auth_gss/gss_spkm3_mech.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/net/sunrpc/auth_gss/gss_spkm3_mech.c b/net/sunrpc/auth_gss/gss_spkm3_mech.c
> index dc3f1f5..adade3d 100644
> --- a/net/sunrpc/auth_gss/gss_spkm3_mech.c
> +++ b/net/sunrpc/auth_gss/gss_spkm3_mech.c
> @@ -100,6 +100,7 @@ gss_import_sec_context_spkm3(const void *p, size_t len,
> if (version != 1) {
> dprintk("RPC: unknown spkm3 token format: "
> "obsolete nfs-utils?\n");
> + p = ERR_PTR(-EINVAL);
> goto out_err_free_ctx;
> }
>
> @@ -135,8 +136,10 @@ gss_import_sec_context_spkm3(const void *p, size_t len,
> if (IS_ERR(p))
> goto out_err_free_intg_alg;
>
> - if (p != end)
> + if (p != end) {
> + p = ERR_PTR(-EFAULT);
> goto out_err_free_intg_key;
> + }
>
> ctx_id->internal_ctx_id = ctx;
>
> --
> 1.7.0
>
>
Ditto. Although, I'm wondering if we shouldn't just start ripping out
the spkm stuff at this point. It is pretty much dead as far as the IETF
is concerned.
Cheers
Trond
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
