Re: bug in match_ipaddr6 ?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 02 Sep 2010 15:36:39 -0700
Ben Greear <greearb@xxxxxxxxxxxxxxx> wrote:

> static int nfs_sockaddr_match_ipaddr6(const struct sockaddr *sa1,
> 				      const struct sockaddr *sa2)
> {
> 	const struct sockaddr_in6 *sin1 = (const struct sockaddr_in6 *)sa1;
> 	const struct sockaddr_in6 *sin2 = (const struct sockaddr_in6 *)sa2;
> 
> 	if (ipv6_addr_scope(&sin1->sin6_addr) == IPV6_ADDR_SCOPE_LINKLOCAL &&
> 	    sin1->sin6_scope_id != sin2->sin6_scope_id)
> 		return 0;
> 
> 	return ipv6_addr_equal(&sin1->sin6_addr, &sin1->sin6_addr);
> 
> Looks like this last line, second argument should be &sin2->sin6_addr ???
> 
> Thanks,
> Ben
> 

Ouch. Yes, that does look wrong. Care to send a patch to fix it?

-- 
Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux