Re: [PATCH] rpc.nfsd: mount up nfsdfs is it doesn't appear to be mounted yet

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 30 Aug 2010 11:51:48 -0400
Steve Dickson <SteveD@xxxxxxxxxx> wrote:

> 
> 
> On 08/28/2010 07:35 AM, Jeff Layton wrote:
> > There's a bit of a chicken and egg problem when nfsd is run the first
> > time. On Fedora/RHEL at least, /proc/fs/nfsd is mounted up whenever nfsd
> > is plugged in via a modprobe.conf "install" directive.
> > 
> > If someone runs rpc.nfsd without plugging in nfsd.ko first,
> > /proc/fs/nfsd won't be mounted and rpc.nfsd will end up using the legacy
> > nfsctl interface. After that, nfsd will be plugged in and subsequent
> > rpc.nfsd invocations will use that instead.
> > 
> > This is a problem as some nfsd command-line options are ignored when the
> > legacy interface is used. It'll also be a problem for people who want
> > IPv6 enabled servers. The upshot is that we really don't want to use the
> > legacy interface unless there is no other option.
> Well maybe its time we stop supporting the legacy interface... I
> would rather stop supporting something nobody uses then added
> some questionable code... Lets just error out when /proc/fs/nfsd
> is not mounted and log what needs to happen...
> 
> steved.
> 

Hmmm...if I had known that it was ok to stop supporting old kernels,
the IPv6 support for rpc.nfsd would have been a heck of a lot easier to
implement.

I'm not sure I like throwing up our hands and bailing out with a log
message. We'll be going from an at least somewhat carefully considered
fallback mechanism to an outright failure to start in this situation.
That doesn't really seem like an improvement to me...

How this as an alternate proposal?

We attempt to mount up nfsdfs. If the "threads" file still isn't
present after the attempt, we then log a warning and go with the
nfsctl() interface?

-- 
Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux