On Sat, Aug 28, 2010 at 10:24:50PM -0400, Jeff Layton wrote: > I considered that when I did this, but didn't know if we could count on > nfsdfs automatically being mounted up when nfsd.ko is plugged in. I > went with calling system() since I figured we'd be making less > assumptions about modprobe.conf configuration. > > FWIW, at least on fedora the /bin/mount here usually returns an > error. /bin/mount calls mount() and that triggers a request_module() > for nfsdfs. That triggers modprobe to mount the fs, and /bin/mount then > returns an error since it's already mounted. The error though is > harmless in this case since the fs gets mounted up anyway. > > If the consensus is that using a no-op nfsctl() call is better than > shelling out to /bin/mount here, then I'll go with that. It seems > though like the patch I've already proposed would allow for nfsdfs to > end up mounted even when modprobe.conf isn't set up to do it. I'd rather not rely on modprobe. It's partly a personal grudge: I usually build nfsd into kernels when I test, and that always requires a minor scuffle or two with init scripts that assume nfsd should be a module. --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
