Re: fsync/wb deadlocks in 2.6.32

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi all,

I'm guessing this is uncommon and nobody here has seen it. One of my
friends looked through the list archives and discovered commit
0702099bd86c33c2dcdbd3963433a61f3f503901, which looked relevant. I
backported it to 2.6.32.18 (if you can call anything involving a one
line patch "backporting" :) ), and the problem has not yet returned.

That said, I'm not sure if this actually corrects the problem or
pushes it deeper into a place where it's not going to hang the host,
but is still unsafe because the original commit was to 2.6.35+. Any
comments?

Thanks!

David



--- linux-2.6.32.18.orig/fs/nfs/file.c  2010-08-10 12:45:57.000000000 -0500
+++ linux-2.6.32.18/fs/nfs/file.c       2010-08-20 10:15:37.608665292 -0500
@@ -220,7 +220,7 @@ static int nfs_do_fsync(struct nfs_open_
       have_error |= test_bit(NFS_CONTEXT_ERROR_WRITE, &ctx->flags);
       if (have_error)
               ret = xchg(&ctx->error, 0);
-       if (!ret)
+       if (!ret && status < 0)
               ret = status;
       return ret;
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux