On Wed, Aug 18, 2010 at 11:46:15PM +0300, Benny Halevy wrote: > On Aug. 18, 2010, 23:31 +0300, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > I don't think such a fine-grained splitup is reviewable at all. > > Anything more than a couple of patches for core nfs client changes, > > one patch for core pnfs support and one for the file layout driver > > is simply too much. > > > > The whole enchilada is about 8500 lines of diff. > Don't you think that splitting it up to self contained bite-sized patches > is better for reviewing it? Depends on your defintion of self contained. If you actually have a first patch with a functional and working subset and just keep adding optimizations or new features that's okay, but otherwise it's poinless. If you submit a single driver / feature it needs to be a reviewed as a whole and not artifical pieces. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
