On 07/21/2010 01:23 PM, Chuck Lever wrote:
> Hi Steve-
>
>>
>> diff --git a/utils/mountd/mountd.c b/utils/mountd/mountd.c
>> index 6571454..43aec11 100644
>> --- a/utils/mountd/mountd.c
>> +++ b/utils/mountd/mountd.c
>> @@ -194,6 +194,9 @@ sig_hup (int sig)
>> bool_t
>> mount_null_1_svc(struct svc_req *rqstp, void *argp, void *resp)
>> {
>> + xlog(D_CALL, "MNT1(%s) null: rqstp %p argp %p resp %p",
>> + rqstp, argp, resp);
>> +
>> return 1;
>> }
>>
>
> I have to agree with Bruce: adding xlog() calls here is the wrong thing
> to do. Instead, use
>
> __attribute__((unused))
>
> for the unused parameters.
Boy... using those really make the code look ugly...
bool_t
mount_null_1_svc(
__attribute__((unused))struct svc_req *rqstp ,
__attribute__((unused))void *argp,
__attribute__((unused))void *resp)
{
return 1;
}
So ugly up the code verses adding a bit more debugging... I must
say I'm leaning toward the latter...
>
>> if (!(exp = auth_authenticate("unmount", sin, p))) {
>> return 1;
>> @@ -247,10 +253,15 @@ mount_umnt_1_svc(struct svc_req *rqstp, dirpath
>> *argp, void *resp)
>> bool_t
>> mount_umntall_1_svc(struct svc_req *rqstp, void *argp, void *resp)
>> {
>> + struct sockaddr_in *sin = nfs_getrpccaller_in(rqstp->rq_xprt);
>> +
>> + xlog(D_CALL, "UMNT1(%s) unmountall: argp %s resp %p",
>> + inet_ntoa(sin->sin_addr), argp, resp);
>> +
>> /* Reload /etc/xtab if necessary */
>> auth_reload();
>>
>> - mountlist_del_all(nfs_getrpccaller_in(rqstp->rq_xprt));
>> + mountlist_del_all(sin);
>
> You couldn't wait until the rest of my IPv6 mountd patches are
> integrated? I address a lot of these problems in those patches, and now
> I'm going to have to rebase all of that work. What's the rush?
No rush.. I just wanted to clean things up...
steved.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
