On 07/21/2010 01:12 PM, J. Bruce Fields wrote:
> On Tue, Jul 20, 2010 at 07:37:21PM -0400, Steve Dickson wrote:
>> mountd.c: In function 'mount_null_1_svc':
>> mountd.c:195: warning: unused parameter 'rqstp'
>> mountd.c:195: warning: unused parameter 'argp'
>> mountd.c:195: warning: unused parameter 'resp'
>> mountd.c: In function 'mount_dump_1_svc':
>> mountd.c:213: warning: unused parameter 'argp'
> ...
>> @@ -214,7 +217,8 @@ mount_dump_1_svc(struct svc_req *rqstp, void *argp, mountlist *res)
>> {
>> struct sockaddr_in *addr = nfs_getrpccaller_in(rqstp->rq_xprt);
>>
>> - xlog(D_CALL, "dump request from %s.", inet_ntoa(addr->sin_addr));
>> + xlog(D_CALL, "MNT1(%s) dump request: argp %p",
>> + inet_ntoa(addr->sin_addr), argp);
>
> Since those are unused, adding them to the debugging log doesn't add any
> useful information.
Well knowing that a client just sent a dump request when debug
is enabled verses not knowing with debug enabled seems it might be
somewhat useful...
>
> The extra warnings is maybe a useful exercise to do every now and then
> to check if it turns up bugs, but I'm not sure forcing all the code to
> pass those tests is worthwhile.
Really... Maybe I'm misunderstanding you but forcing all the code to
compile warning free is a really good thing...
steved.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
