On Thu, Jul 22, 2010 at 07:59:39AM -0400, Staubach_Peter@xxxxxxx wrote:
> +static int nfsd_init_socks(int port)
> +{
> + int error;
> + if (!list_empty(&nfsd_serv->sv_permsocks))
> + return 0;
> +
> + error = svc_create_xprt(nfsd_serv, "udp", PF_INET, port,
> + SVC_SOCK_DEFAULTS);
> + if (error < 0)
> + return error;
> +
> + error = svc_create_xprt(nfsd_serv, "tcp", PF_INET, port,
> + SVC_SOCK_DEFAULTS);
> + if (error < 0)
> + return error;
>
> Doesn't this leave something dangling if svc_create_xprt for "udp"
> succeeds,
> but svc_create_xprt for "tcp" fails?
Yeah, but those sockets are all cleaned up when nfsd_serv is destroyed,
so I think we can live with this.
--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
