Re: [PATCH 24/24] Removed warnings from configfile.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Steve-

On 07/20/10 07:37 PM, Steve Dickson wrote:
configfile.c:195: warning: 'inline' is not at beginning of declaration
configfile.c:232: warning: 'inline' is not at beginning of declaration

Signed-off-by: Steve Dickson<steved@xxxxxxxxxx>
---
  utils/mount/configfile.c |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/utils/mount/configfile.c b/utils/mount/configfile.c
index 5cff009..3f3b249 100644
--- a/utils/mount/configfile.c
+++ b/utils/mount/configfile.c
@@ -192,7 +192,7 @@ void free_all(void)
  	}
  }
  static char *versions[] = {"v2", "v3", "v4", "vers", "nfsvers", NULL};
-int inline check_vers(char *mopt, char *field)
+inline int check_vers(char *mopt, char *field)

I don't see the purpose of using inline here, nor of keeping this a global function. Is "inline" is addressing some Fortify warning?

If you're updating this, shouldn't it rather be:

static int
check_vers(char *mopt, char *field)

?

  {
  	int i, found=0;

@@ -229,7 +229,7 @@ extern sa_family_t config_default_family;
   * If so, set the appropriate global value which will
   * be used as the initial value in the server negation.
   */
-int inline default_value(char *mopt)
+inline int default_value(char *mopt)
  {
  	struct mount_options *options = NULL;
  	int dftlen = strlen("default");

And likewise...?
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux