On Mon, 19 Jul 2010 18:08:37 -0400 "J. Bruce Fields" <bfields@xxxxxxxxxxxx> wrote: > On Mon, Jul 19, 2010 at 04:50:04PM -0400, Jeff Layton wrote: > > If someone tries to shut down the laundry_wq while it isn't up it'll > > cause an oops. > > nfs4_state_shutdown is called only from nfsd_last_thread, which is > called only after svc_create_pooled, which is called only when > nfs4_state_start() succeeds. > > If you've actually seen this happen then there's something going on that > I don't understand. > > --b. I've not seen this in current code, but this delta is a prerequisite for the next patch in the series. It's possible for nfsd_serv to be created (via the write_ports interface), but for the threads file never to be written. With the next patch in the series, the nfsd_serv can be torn down in an error condition before the threads file is ever written and at that point this patch is required to prevent panics. Cheers, -- Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
