OK - Thanks for the heads up -->Andy On Jul 19, 2010, at 4:46 AM, Benny Halevy wrote: > Andy, I've fixed this already in my tree, but with additionaly > checking on nfs4_sequence_done's status: > > if (!nfs4_sequence_done(task, &res)) > return 0; > > Benny > > On Jul. 16, 2010, 18:56 +0300, andros@xxxxxxxxxx wrote: >> From: Andy Adamson <andros@xxxxxxxxxx> >> >> Signed-off-by: Andy Adamson <andros@xxxxxxxxxx> >> --- >> fs/nfs/nfs4proc.c | 6 +++--- >> 1 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c >> index f5779a1..17b0c31 100644 >> --- a/fs/nfs/nfs4proc.c >> +++ b/fs/nfs/nfs4proc.c >> @@ -5448,7 +5448,7 @@ static void nfs4_pnfs_layoutget_done(struct rpc_task *task, void *calldata) >> >> dprintk("--> %s\n", __func__); >> >> - nfs4_sequence_done(server, &lgp->res.seq_res, task->tk_status); >> + nfs4_sequence_done(task, &lgp->res.seq_res); >> >> if (RPC_ASSASSINATED(task)) >> return; >> @@ -5558,7 +5558,7 @@ pnfs_layoutcommit_done(struct rpc_task *task, void *calldata) >> (struct pnfs_layoutcommit_data *)calldata; >> struct nfs_server *server = NFS_SERVER(data->args.inode); >> >> - nfs4_sequence_done(server, &data->res.seq_res, task->tk_status); >> + nfs4_sequence_done(task, &data->res.seq_res); >> if (RPC_ASSASSINATED(task)) >> return; >> >> @@ -5666,7 +5666,7 @@ static void nfs4_pnfs_layoutreturn_done(struct rpc_task *task, void *calldata) >> >> dprintk("--> %s\n", __func__); >> >> - nfs4_sequence_done(server, &lrp->res.seq_res, task->tk_status); >> + nfs4_sequence_done(task, &lrp->res.seq_res); >> if (RPC_ASSASSINATED(task)) >> return; >> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html