> --- /dev/null
> +++ b/include/linux/sunrpc/simple_rpc_pipefs.h
> @@ -0,0 +1,112 @@
> +/*
> + * linux/fs/gfs2/simple_rpc_pipefs.h
There's a reason why these kind of filename comments are useless, and
you have just proven it.
> +#include <linux/fs.h>
> +#include <linux/list.h>
> +#include <linux/mount.h>
> +#include <linux/sched.h>
> +#include <linux/sunrpc/clnt.h>
> +#include <linux/sunrpc/rpc_pipe_fs.h>
Do you actually need all these in a header? I suspect many could go
away in favour of forward declarations.
> +typedef struct pipefs_hdr {
> + u32 msgid;
> + u8 type;
> + u8 flags;
> + u16 totallen; /* length of entire message, including hdr itself */
> + u32 status;
> +} pipefs_hdr_t;
> +typedef struct pipefs_list {
> + struct list_head list;
> + spinlock_t list_lock;
> +} pipefs_list_t;
Please do not add typedefs for your structures.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
