If only nfs_alloc_fhandle XOR nfs_alloc_fattr returns NULL the function fails to free the other struct. Signed-off-by: Benny Halevy <bhalevy@xxxxxxxxxxx> --- fs/nfs/proc.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/nfs/proc.c b/fs/nfs/proc.c index 52790a4..1837a05 100644 --- a/fs/nfs/proc.c +++ b/fs/nfs/proc.c @@ -443,7 +443,7 @@ nfs_proc_symlink(struct inode *dir, struct dentry *dentry, struct page *page, fattr = nfs_alloc_fattr(); status = -ENOMEM; if (fh == NULL || fattr == NULL) - goto out; + goto out_free; status = rpc_call_sync(NFS_CLIENT(dir), &msg, 0); nfs_mark_for_revalidate(dir); @@ -455,7 +455,7 @@ nfs_proc_symlink(struct inode *dir, struct dentry *dentry, struct page *page, */ if (status == 0) status = nfs_instantiate(dentry, fh, fattr); - +out_free: nfs_free_fattr(fattr); nfs_free_fhandle(fh); out: -- 1.6.6.1 -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
